[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    PATCH - missing KHTML_EXPORT on some Dom classes
From:       Jason Keirstead <jason () keirstead ! org>
Date:       2005-01-03 21:05:26
Message-ID: 200501031705.26908.jason () keirstead ! org
[Download RAW message or body]

I was trying  to create a CustomNodeFilter to use with a NodeIterator in my 
app, when I discovered these classes were not being exported properly, so I 
could not use them at all. Is there a reason for this? I have noticed no ill 
effects by exporting these classes, and now my app compiles and runs 
correctly.


-- 
If you wait by the river long enough, eventually
you will see the bodies of all your enemies float by.
    - Sun Tzu

["visibility.patch" (text/x-diff)]

? visibility.patch
Index: dom/dom2_traversal.h
===================================================================
RCS file: /home/kde/kdelibs/khtml/dom/dom2_traversal.h,v
retrieving revision 1.22
diff -u -p -b -w -B -r1.22 dom2_traversal.h
--- dom/dom2_traversal.h	4 Feb 2004 16:52:05 -0000	1.22
+++ dom/dom2_traversal.h	3 Jan 2005 21:02:05 -0000
@@ -56,7 +56,7 @@ class CustomNodeFilterImpl;
  * interface.
  *
  */
-class NodeIterator
+class KHTML_EXPORT NodeIterator
 {
     friend class NodeIteratorImpl;
     friend class Document;
@@ -180,7 +180,7 @@ protected:
  * an instance of it to the NodeFilter. For more details see the
  * CustomNodeFilter class
  */
-class NodeFilter
+class KHTML_EXPORT NodeFilter
 {
     friend class NodeIterator;
     friend class NodeIteratorImpl;
@@ -291,7 +291,7 @@ protected:
  *
  */
 
-class CustomNodeFilter : public DomShared {
+class KHTML_EXPORT CustomNodeFilter : public DomShared {
 public:
     CustomNodeFilter();
     virtual ~CustomNodeFilter();


[prev in list] [next in list] [prev in thread] [next in thread]