[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Patch for kaboutapplication
From:       David Faure <faure () kde ! org>
Date:       2004-12-26 23:52:49
Message-ID: 200412270052.49940.faure () kde ! org
[Download RAW message or body]

On Monday 27 December 2004 00:11, Albert Astals Cid wrote:
> +    if (!aboutData->bugAddress().isEmpty())

Ok with me, but I would always show something, even if bugAddress is empty,
so I would suggest
 if ( aboutData->bugAddress().isEmpty() || aboutData->bugAddress() == "submit@bugs.kde.org")

Not that it should ever happen, but the code reads strange if there's a code 
path where nothing is printed.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]