From kde-core-devel  Tue Dec 07 20:18:50 2004
From: =?utf-8?q?Andr=C3=A9_W=C3=B6bbeking?= <Woebbeking () onlinehome ! de>
Date: Tue, 07 Dec 2004 20:18:50 +0000
To: kde-core-devel
Subject: KApplication::invokeMailer() crash
Message-Id: <200412072118.50965.Woebbeking () onlinehome ! de>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=110245073801199
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary-00=_qAhtB2sV3/3I72K"

--Boundary-00=_qAhtB2sV3/3I72K
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi,

the method crashes for me if it's called by=20
KonqMainWindow::slotSendURL()  because "to" is QString::null. Can I=20
commit the attached patch or should "to" be set to something like=20
"unknown"?=20


Cheers,
Andr=C3=A9

--Boundary-00=_qAhtB2sV3/3I72K
Content-Type: text/x-diff;
  charset="us-ascii";
  name="invokeMailer.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="invokeMailer.diff"

Index: kapplication.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kapplication.cpp,v
retrieving revision 1.689
diff -u -3 -p -r1.689 kapplication.cpp
--- kapplication.cpp	2 Dec 2004 13:13:28 -0000	1.689
+++ kapplication.cpp	7 Dec 2004 20:11:21 -0000
@@ -2269,17 +2269,19 @@ void KApplication::invokeMailer(const QS
    cmdTokens.remove(cmdTokens.begin());
 
    KURL url;
-   url.setProtocol( "mailto" );
-   QStringList tos = QStringList::split( ',', to );
-   url.setPath( tos.first() );
-   tos.remove( tos.begin() );
    QStringList qry;
-   for (QStringList::ConstIterator it = tos.begin(); it != tos.end(); ++it)
-      qry.append( "to=" + KURL::encode_string( *it ) );
-   QStringList ccs = QStringList::split( ',', cc );
+   if (!to.isEmpty())
+   {
+     QStringList tos = QStringList::split( ',', to );
+     url.setPath( tos.first() );
+     tos.remove( tos.begin() );
+     for (QStringList::ConstIterator it = tos.begin(); it != tos.end(); ++it)
+       qry.append( "to=" + KURL::encode_string( *it ) );
+   }
+   const QStringList ccs = QStringList::split( ',', cc );
    for (QStringList::ConstIterator it = ccs.begin(); it != ccs.end(); ++it)
       qry.append( "cc=" + KURL::encode_string( *it ) );
-   QStringList bccs = QStringList::split( ',', bcc );
+   const QStringList bccs = QStringList::split( ',', bcc );
    for (QStringList::ConstIterator it = bccs.begin(); it != bccs.end(); ++it)
       qry.append( "bcc=" + KURL::encode_string( *it ) );
    for (QStringList::ConstIterator it = attachURLs.begin(); it != attachURLs.end(); ++it)

--Boundary-00=_qAhtB2sV3/3I72K--