[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [PATCH] Please review small DCOP -fvisibility patch
From:       Unai Garro <ugarro () telefonica ! net>
Date:       2004-11-28 11:57:41
Message-ID: 200411281257.41462.ugarro () telefonica ! net
[Download RAW message or body]

dcopidl2cpp "forgets" to KDE_EXPORT methods functions(), process(..) and 
interfaces(), so it breaks building programs like kmplayer (using 
kmediaplayer in kdelibs, which gets those symbols hidden). I attach a patch 
that fixes it. 

The patch works for me, but as I don't know much about DCOP I'd like someone 
to verify this. Everything is OK there? Should I commit?

Regards,
	Unai

["dcopVisibilityPatch.diff" (text/x-diff)]

? dcopVisibilityPatch.diff
Index: dcopidl2cpp/skel.cpp
===================================================================
RCS file: /home/kde/kdelibs/dcop/dcopidl2cpp/skel.cpp,v
retrieving revision 1.31
diff -u -3 -p -u -r1.31 skel.cpp
--- dcopidl2cpp/skel.cpp	21 Oct 2004 01:44:39 -0000	1.31
+++ dcopidl2cpp/skel.cpp	28 Nov 2004 11:56:45 -0000
@@ -211,7 +211,7 @@ void generateSkel( const QString& idl, c
     
     
 	// Write dispatcher
-	str << "bool " << className;
+	str << "KDE_EXPORT bool " << className;
 	str << "::process(const QCString &fun, const QByteArray &data, QCString& replyType, \
QByteArray &replyData)" << endl;  str << "{" << endl;
 	if ( useHashing ) {
@@ -333,7 +333,7 @@ void generateSkel( const QString& idl, c
 	// close the 'process' function
 	str << "}" << endl << endl;
     
-	str << "QCStringList " << className;
+	str << "KDE_EXPORT QCStringList " << className;
 	str << "::interfaces()" << endl;
 	str << "{" << endl;
 	if (!DCOPParent.isEmpty()) {
@@ -346,7 +346,7 @@ void generateSkel( const QString& idl, c
 	str << "}" << endl << endl;
 	
 	
-	str << "QCStringList " << className;
+	str << "KDE_EXPORT QCStringList " << className;
 	str << "::functions()" << endl;
 	str << "{" << endl;
 	if (!DCOPParent.isEmpty()) {



[prev in list] [next in list] [prev in thread] [next in thread]