[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Still problems with gcc 3.4 and visibility
From:       Simone Gotti <simone.gotti () email ! it>
Date:       2004-11-26 10:11:02
Message-ID: 200411261106.10591.simone.gotti () email ! it
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On Tuesday 23 November 2004 11:20, LuisMi Castilla wrote:
> Hi, I have been following the discussion about compiling kde-head with gcc
> 3.4
> with visibility patches (gcc 3.4.3 from gentoo).
>
> Yesterday I couldn't compile it, but with dirk's fixes it compiles ok. The
> problem is that konqueror, the taskbar and trayicon don't work correctly,
> so I think it's still failing.
>
> trying to open konqueror reports this:
>
> The konq_sidebar library does not offer init_konq_sidebar function  (or
> something like that, because I have it in spanish).
>
> Please, CC me if you need for me to try if it works, as I'm not subscribed.

Thanks to the  Jaroslaw Staniek suggestions I've fixed the missing konqueror's 
exported symbols. Now the sidebar and the verious views should work.

Can someone review and tell me if I can commit it?

Bye!
-- 
Simone Gotti - Gentoo Developer
<simone.gotti@email.it> - <motaboy@gentoo.org>
http://kde-bluetooth.sf.net

["konqueror-visibility-fix-01.patch" (text/x-diff)]

? konqueror-visibility-fix-01.patch
Index: about/konq_aboutpage.cc
===================================================================
RCS file: /home/kde/kdebase/konqueror/about/konq_aboutpage.cc,v
retrieving revision 1.61
diff -u -b -B -r1.61 konq_aboutpage.cc
--- about/konq_aboutpage.cc	10 Oct 2004 14:36:06 -0000	1.61
+++ about/konq_aboutpage.cc	26 Nov 2004 10:03:11 -0000
@@ -15,13 +15,8 @@
 #include <assert.h>
 #include <qfile.h>
 
-extern "C"
-{
-    void *init_konq_aboutpage()
-    {
-        return new KonqAboutPageFactory;
-    }
-}
+
+K_EXPORT_COMPONENT_FACTORY( konq_aboutpage, KonqAboutPageFactory )
 
 KInstance *KonqAboutPageFactory::s_instance = 0;
 QString *KonqAboutPageFactory::s_intro_html = 0;
Index: iconview/konq_iconview.cc
===================================================================
RCS file: /home/kde/kdebase/konqueror/iconview/konq_iconview.cc,v
retrieving revision 1.480
diff -u -b -B -r1.480 konq_iconview.cc
--- iconview/konq_iconview.cc	18 Nov 2004 19:04:45 -0000	1.480
+++ iconview/konq_iconview.cc	26 Nov 2004 10:03:13 -0000
@@ -105,13 +105,9 @@
 KInstance *KonqIconViewFactory::s_instance = 0;
 KonqPropsView *KonqIconViewFactory::s_defaultViewProps = 0;
 
-extern "C"
-{
-    void *init_konq_iconview()
-    {
-        return new KonqIconViewFactory;
-    }
-}
+
+K_EXPORT_COMPONENT_FACTORY( konq_iconview, KonqIconViewFactory )
+
 
 IconViewBrowserExtension::IconViewBrowserExtension( KonqKfmIconView *iconView )
  : KonqDirPartBrowserExtension( iconView )
Index: listview/konq_listview.cc
===================================================================
RCS file: /home/kde/kdebase/konqueror/listview/konq_listview.cc,v
retrieving revision 1.214
diff -u -b -B -r1.214 konq_listview.cc
--- listview/konq_listview.cc	18 Nov 2004 19:04:46 -0000	1.214
+++ listview/konq_listview.cc	26 Nov 2004 10:03:14 -0000
@@ -90,13 +90,7 @@
 KInstance *KonqListViewFactory::s_instance = 0;
 KonqPropsView *KonqListViewFactory::s_defaultViewProps = 0;
 
-extern "C"
-{
-  void *init_konq_listview()
-  {
-    return new KonqListViewFactory;
-  }
-}
+K_EXPORT_COMPONENT_FACTORY( konq_listview, KonqListViewFactory )
 
 ListViewBrowserExtension::ListViewBrowserExtension( KonqListView *listView )
  : KonqDirPartBrowserExtension( listView )
Index: sidebar/konqsidebar.cpp
===================================================================
RCS file: /home/kde/kdebase/konqueror/sidebar/konqsidebar.cpp,v
retrieving revision 1.28
diff -u -b -B -r1.28 konqsidebar.cpp
--- sidebar/konqsidebar.cpp	28 Oct 2004 20:52:38 -0000	1.28
+++ sidebar/konqsidebar.cpp	26 Nov 2004 10:03:14 -0000
@@ -120,12 +120,6 @@
 	return s_instance;
 }
 
-extern "C"
-{
-	void* init_konq_sidebar()
-	{
-		return new KonqSidebarFactory;
-	}
-}
+K_EXPORT_COMPONENT_FACTORY( konq_sidebar, KonqSidebarFactory )
 
 #include "konqsidebar.moc"
Index: sidebar/test/konqsidebartest.cpp
===================================================================
RCS file: /home/kde/kdebase/konqueror/sidebar/test/konqsidebartest.cpp,v
retrieving revision 1.8
diff -u -b -B -r1.8 konqsidebartest.cpp
--- sidebar/test/konqsidebartest.cpp	2 Mar 2003 12:17:31 -0000	1.8
+++ sidebar/test/konqsidebartest.cpp	26 Nov 2004 10:03:14 -0000
@@ -19,7 +19,7 @@
 
 extern "C"
 {
-    void* create_konq_sidebartest(KInstance *instance,QObject *par,QWidget \
*widp,QString &desktopname,const char *name) +    KDE_EXPORT void* \
create_konq_sidebartest(KInstance *instance,QObject *par,QWidget *widp,QString \
&desktopname,const char *name)  {
         return new SidebarTest(instance,par,widp,desktopname,name);
     }
Index: sidebar/trees/konqsidebar_tree.cpp
===================================================================
RCS file: /home/kde/kdebase/konqueror/sidebar/trees/konqsidebar_tree.cpp,v
retrieving revision 1.14
diff -u -b -B -r1.14 konqsidebar_tree.cpp
--- sidebar/trees/konqsidebar_tree.cpp	25 Aug 2003 14:19:46 -0000	1.14
+++ sidebar/trees/konqsidebar_tree.cpp	26 Nov 2004 10:03:14 -0000
@@ -101,7 +101,7 @@
 
 extern "C"
 {
-    void* create_konqsidebar_tree(KInstance *inst,QObject *par,QWidget *widp,QString \
&desktopname,const char *name) +    KDE_EXPORT void*  \
create_konqsidebar_tree(KInstance *inst,QObject *par,QWidget *widp,QString \
&desktopname,const char *name)  {
         return new KonqSidebar_Tree(inst,par,widp,desktopname,name);
     }
@@ -109,7 +109,7 @@
 
 extern "C"
 {
-   bool add_konqsidebar_tree(QString* fn, QString*, QMap<QString,QString> *map)
+   KDE_EXPORT bool add_konqsidebar_tree(QString* fn, QString*, QMap<QString,QString> \
*map)  {
 	  KStandardDirs *dirs=KGlobal::dirs();
 	  QStringList list=dirs->findAllResources("data","konqsidebartng/dirtree/*.desktop",false,true);
                
Index: sidebar/trees/bookmark_module/bookmark_module.cpp
===================================================================
RCS file: /home/kde/kdebase/konqueror/sidebar/trees/bookmark_module/bookmark_module.cpp,v
 retrieving revision 1.10
diff -u -b -B -r1.10 bookmark_module.cpp
--- sidebar/trees/bookmark_module/bookmark_module.cpp	9 Nov 2004 22:11:59 -0000	1.10
+++ sidebar/trees/bookmark_module/bookmark_module.cpp	26 Nov 2004 10:03:15 -0000
@@ -541,7 +541,7 @@
 
 extern "C"
 {
-   KonqSidebarTreeModule* create_konq_sidebartree_bookmarks(KonqSidebarTree* \
par,const bool) +   KDE_EXPORT KonqSidebarTreeModule* \
create_konq_sidebartree_bookmarks(KonqSidebarTree* par,const bool)  {
 		return new KonqSidebarBookmarkModule(par);
 	} 
Index: sidebar/trees/dirtree_module/dirtree_module.cpp
===================================================================
RCS file: /home/kde/kdebase/konqueror/sidebar/trees/dirtree_module/dirtree_module.cpp,v
 retrieving revision 1.40
diff -u -b -B -r1.40 dirtree_module.cpp
--- sidebar/trees/dirtree_module/dirtree_module.cpp	25 Oct 2004 14:18:29 -0000	1.40
+++ sidebar/trees/dirtree_module/dirtree_module.cpp	26 Nov 2004 10:03:16 -0000
@@ -616,7 +616,7 @@
 
 extern "C"
 {
-        KonqSidebarTreeModule *create_konq_sidebartree_dirtree(KonqSidebarTree* \
par,const bool showHidden) +        KDE_EXPORT KonqSidebarTreeModule \
*create_konq_sidebartree_dirtree(KonqSidebarTree* par,const bool showHidden)  {
 		return new KonqSidebarDirTreeModule(par,showHidden);
 	}
Index: sidebar/trees/history_module/history_module.cpp
===================================================================
RCS file: /home/kde/kdebase/konqueror/sidebar/trees/history_module/history_module.cpp,v
 retrieving revision 1.21
diff -u -b -B -r1.21 history_module.cpp
--- sidebar/trees/history_module/history_module.cpp	12 May 2004 20:30:37 -0000	1.21
+++ sidebar/trees/history_module/history_module.cpp	26 Nov 2004 10:03:16 -0000
@@ -355,7 +355,7 @@
 
 extern "C"
 {
-	KonqSidebarTreeModule* create_konq_sidebartree_history(KonqSidebarTree* par, const \
bool) +	KDE_EXPORT KonqSidebarTreeModule* \
create_konq_sidebartree_history(KonqSidebarTree* par, const bool)  {
 		return new KonqSidebarHistoryModule(par);
 	}
Index: sidebar/web_module/web_module.cpp
===================================================================
RCS file: /home/kde/kdebase/konqueror/sidebar/web_module/web_module.cpp,v
retrieving revision 1.16
diff -u -b -B -r1.16 web_module.cpp
--- sidebar/web_module/web_module.cpp	11 Nov 2004 16:22:29 -0000	1.16
+++ sidebar/web_module/web_module.cpp	26 Nov 2004 10:03:16 -0000
@@ -182,14 +182,14 @@
 
 
 extern "C" {
-	KonqSidebarPlugin* create_konqsidebar_web(KInstance *instance, QObject *parent, \
QWidget *widget, QString &desktopName, const char *name) { +	KDE_EXPORT \
KonqSidebarPlugin* create_konqsidebar_web(KInstance *instance, QObject *parent, \
QWidget *widget, QString &desktopName, const char *name) {  return new \
KonqSideBarWebModule(instance, parent, widget, desktopName, name);  }
 }
 
 
 extern "C" {
-	bool add_konqsidebar_web(QString* fn, QString* param, QMap<QString,QString> *map) {
+	KDE_EXPORT bool add_konqsidebar_web(QString* fn, QString* param, \
QMap<QString,QString> *map) {  Q_UNUSED(param);
 		KGlobal::dirs()->addResourceType("websidebardata", \
KStandardDirs::kde_default("data") + "konqsidebartng/websidebar");  KURL url;


[Attachment #6 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]