[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Supporting GNU ld's --as-needed flag
From:       David Faure <faure () kde ! org>
Date:       2004-11-05 22:53:48
Message-ID: 200411052353.49887.faure () kde ! org
[Download RAW message or body]

On Friday 05 November 2004 23:04, Szombathelyi Gyà ¶rgy wrote:
> 2004. november 4. 18.12 dátummal David Faure ezt írta:
> > On Sunday 17 October 2004 19:13, Szombathelyi György wrote:
> >
> > I asked Michael Matz and he said the patch looks OK, so I'm about to commit
> > it.
> >
> > But why does the patch say:
> > +  KDE_NO_UNDEFINED=""
> > (unconditionally)
> >
> > Does this mean there is no support for checking for undefined symbols
> > anymore? We still need that, at least in debug builds (for developers).
> > For end users (--disable-debug) it's ok if there's no more no-undefined
> > test when linking.
> 
> Oh, thanks for finally considering the patch!
> I don't remember why the KDE_NO_UNDEFINED="" needed, but now I tested without 
> it, and seems to work. Also it doesn't really cleared the variable, because 
> the check for -Wl,--no-undefined is after the new check. So please delete 
> this line.

Ah I see, it was probably a copy-n-paste error (from KDE_CHECK_CLOSURE).

OK applied now. Did you also send the libtool patch to the libtool developers?

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]