[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    kdelibs/kdecore/network
From:       Thiago Macieira <thiago.macieira () kdemail ! net>
Date:       2004-09-19 16:11:12
Message-ID: 20040919161112.CCB8D126B7 () office ! kde ! org
[Download RAW message or body]

CVS commit by thiago: 

Adding a workaround for g++ compiler bug. We shouldn't have to do
that...

KStreamSocket has changed behaviours and is now blocking by default,
while KBufferedSocket now contains a bug it previously didn't.

CCMAIL:kde-core-devel@kde.org,kopete-devel@kde.org,l.savernik@aon.at


  M +0 -1      kbufferedsocket.cpp   1.9
  M +11 -3     kbufferedsocket.h   1.9
  M +0 -1      kstreamsocket.cpp   1.13
  M +3 -0      kstreamsocket.h   1.11


--- kdelibs/kdecore/network/kbufferedsocket.h  #1.8:1.9
@@ -41,5 +41,13 @@ class KBufferedSocketPrivate;
  * This class allows the user to create and operate buffered stream sockets
  * such as those used in most Internet connections. This class is
- * also the one that resembles the most to the old @ref QSocket implementation.
+ * also the one that resembles the most to the old @ref QSocket
+ * implementation.
+ *
+ * Objects of this type operate only in non-blocking mode. A call to
+ * setBlocking(true) will result in an error.
+ *
+ * @bug Because of a bug in g++ 2.95.x, this class may return true to
+ *      isBlocking() under some circumstances, even though the socket
+ *      is not blocking.
  *
  * @author Thiago Macieira <thiago.macieira@kdemail.net>
@@ -57,5 +65,5 @@ public:
    * @param name        the internal name for this object
    */
-  KBufferedSocket(const QString& host = QString::null, const QString& service = QString::null,
+  KBufferedSocket(const QString& node = QString::null, const QString& service = QString::null,
                   QObject* parent = 0L, const char *name = 0L);
 
@@ -72,5 +80,5 @@ public:
 protected:
   /**
-   * Buffered sockets can only operate in blocking mode.
+   * Buffered sockets can only operate in non-blocking mode.
    */
   virtual bool setSocketOptions(int opts);

--- kdelibs/kdecore/network/kbufferedsocket.cpp  #1.8:1.9
@@ -53,5 +53,4 @@ KBufferedSocket::KBufferedSocket(const Q
     d(new KBufferedSocketPrivate)
 {
-  setBlocking(false);
   setInputBuffering(true);
   setOutputBuffering(true);

--- kdelibs/kdecore/network/kstreamsocket.h  #1.10:1.11
@@ -44,4 +44,7 @@ class KStreamSocketPrivate;
  * uses TCP/IP sockets.
  *
+ * Objects of this class start, by default, on blocking mode. Call
+ * setBlocking if you wish to change that.
+ *
  * Sample usage:
  * \code

--- kdelibs/kdecore/network/kstreamsocket.cpp  #1.12:1.13
@@ -58,5 +58,4 @@ KStreamSocket::KStreamSocket(const QStri
   peerResolver().setFamily(KResolver::KnownFamily);
   localResolver().setFamily(KResolver::KnownFamily);
-  setBlocking(false);
 
   QObject::connect(&d->timer, SIGNAL(timeout()), this, SLOT(timeoutSlot()));


[prev in list] [next in list] [prev in thread] [next in thread]