[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [PATCH] Fixing the search for KAboutData (#87536)
From:       Nicolas Goutte <nicolasg () snafu ! de>
Date:       2004-09-13 22:06:43
Message-ID: 200409140006.43097.nicolasg () snafu ! de
[Download RAW message or body]

The attached patch is for the file kde-common/admin/cvs.sh

It tries to fix the search for KAboutData in source to add the necessary i18n 
entries so that the translators can add their names and emails to the 
application translation.

Reason:
- "grep -r *.c* *.C*" would only recurse when finding directory matching that 
pattern which is not possible.

Changes:
- use *.h* as some KAboutData are only defined there.
- remove *.C* as using *.C as extension is not allowed anymore in KDE for a 
few years now.
- use -s for grep, as the first find is more than enough for us.

This should probably backported to the 2 current stable branches, 
KDE_3_3_BRANCH and KOFFICE_1_3_BRANCH. But perhaps testing it first in CVS 
HEAD would perhaps be better.

This fix is part of bug #87536 but it is not sure if this fix is sufficient 
for fixing the complete bug.

Have a nice day!

["cvs_sh.diff" (text/x-diff)]

Index: cvs.sh
===================================================================
RCS file: /home/kde/kde-common/admin/cvs.sh,v
retrieving revision 1.131
diff -u -p -r1.131 cvs.sh
--- cvs.sh	18 Aug 2004 12:39:20 -0000	1.131
+++ cvs.sh	13 Sep 2004 21:59:26 -0000
@@ -575,7 +575,7 @@ for subdir in $dirs; do
 	    echo "$subdir has *.rc, *.ui or *.kcfg files, but not correct messages line"
 	fi
    fi
-   if test -n "`grep -r KAboutData *.c* *.C* 2>/dev/null`"; then
+   if test -n "`find . -name \*.c\* -o -name \*.h\* | xargs grep -s KAboutData \
2>/dev/null`"; then  echo -e 'i18n("_: NAME OF TRANSLATORS\\n"\n"Your \
names")\ni18n("_: EMAIL OF TRANSLATORS\\n"\n"Your emails")' > _translatorinfo.cpp  \
else echo " " > _translatorinfo.cpp  fi



[prev in list] [next in list] [prev in thread] [next in thread]