[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KImageEffect compile fixes/ bug fixes
From:       Jarosław_Staniek <js () iidea ! pl>
Date:       2004-09-13 15:56:57
Message-ID: 4145D185.5080404 () iidea ! pl
[Download RAW message or body]

> Ian Reinhart Geiser said:
> 
>>Jaros^(3)aw Staniek said:
>>
>>>ok?
>>
>>no not okay.
>>
>>whats it do? tests are useful for this sort of thing.
>>
>>cheers
>>   -ian reinhart geiser
> 
> the zero out the struct is cool, but im not sure what the double cast
> accomplishes... this code is basicly untested, and the limited tests we
> have done on it, cause odd behavior when you do "correct" casts.
> 
> Do you have a test that this in fact fixes anything?

Yes, using win32, execute

nmake

in kdefx/ directory. Without the patch there is compilter error (sqrt() has 
many overloads). With the patch all is ok. Enough?

-- 
regards / pozdrawiam,
   Jaroslaw Staniek / OpenOffice Polska
   Kexi project: http://koffice.org/kexi/ http://www.kexi-project.org/
   Qt-KDE Wrapper project: http://iidea.pl/~js/qkw/

[prev in list] [next in list] [prev in thread] [next in thread]