[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdelibs/win32 : kdecore patch
From:       Jarosław_Staniek <js () iidea ! pl>
Date:       2004-09-08 10:38:21
Message-ID: 200409081238.21782.js () iidea ! pl
[Download RAW message or body]

Harri Porten wrote:

> On Wed, 8 Sep 2004, [iso-8859-2] Jarosław Staniek wrote:
> 
>> I must admit there are few completely ifdef'd (using Q_WS_WIN, W_OS_UNIX
>> etc) methods especially in kdecore now. Most of these are waiting for
>> such wrapper classes or just wrapped methods, implemented in *_win.cpp
>> files (as Qt does), with volunteers' help :)
> 
> I know that things are not that simple to accomplish in reality :)
> Sometimes it might indeed be more effective to #ifdef a few calls instead
> of creating a new platform independant API.
> 
> My point is just that K_WS_QTONLY (appearantly meaning !Q_WS_X11 &&
> !Q_WS_WIN && !Q_WS_MAC) does not really help with porting to other
> platforms. It just makes the code harder to understand. Why not guard the
> code with #ifdef Q_WS_X11 etc. right away?

I am voting for this as well. K_WS_QTONLY is from me, but from Holger 
Schroeder. I've left it as is to avoid problems is somebody depend on it. 

So, is it still used, Holger?

-- 
regards / pozdrawiam,
  Jaroslaw Staniek / OpenOffice Polska
  Kexi Project: http://www.kexi-project.org, http://koffice.kde.org/kexi
  QT-KDE Wrapper Project: http://iidea.pl/~js/qkw

[prev in list] [next in list] [prev in thread] [next in thread]