[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdelibs/win32 : kdecore patch
From:       Jarosław_Staniek <js () iidea ! pl>
Date:       2004-09-08 7:27:55
Message-ID: 200409080927.55785.js () iidea ! pl
[Download RAW message or body]

Harri Porten wrote:

> I also think that those #ifdefs are sometimes placed at strategically
> suboptimal points. Instead of disabling all those places *using* a class
> it's better to make the changes to the class itself. Either by writing a
> new (possibly dummy) class or putting #ifdefs into the implementation of
> the original class.

I must admit there are few completely ifdef'd (using Q_WS_WIN, W_OS_UNIX etc) 
methods especially in kdecore now. Most of these are waiting for such wrapper 
classes or just wrapped methods, implemented in *_win.cpp files (as Qt does), 
with volunteers' help :)

-- 
regards / pozdrawiam,
  Jaroslaw Staniek / OpenOffice Polska
  Kexi Project: http://www.kexi-project.org, http://koffice.kde.org/kexi
  QT-KDE Wrapper Project: http://iidea.pl/~js/qkw
[prev in list] [next in list] [prev in thread] [next in thread]