[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: job.cpp
From:       Jarosław Staniek <js () iidea ! pl>
Date:       2004-09-06 10:44:52
Message-ID: 413C4DE7.40306 () iidea ! pl
[Download RAW message or body]


> On Monday 06 September 2004 13:09, Jarosław Staniek wrote:
> 
>>In QFile *CacheInfo::cachedFile(), shouldn't we have
>>
>>fopen(QFile::encodeName(CEF), mode)
>>
>>instead of fopen(CEF.latin1(), mode)?
>>The same question goes for unlink().
> 
> 
> Yes, please go ahead. This was either introduced after I went through the code 
> with search and replace (quite some time ago) or I missed it.
> 
> Reasoning for the curious: That holds true for all situations where file names 
> need to be converted to local8bit. encodeName() knows the correct one.

So I can just add this fix to my (incoming) kio/win32 patch...

-- 
regards / pozdrawiam,
   Jaroslaw Staniek / OpenOffice Polska
   Kexi project: http://koffice.org/kexi/ http://www.kexi-project.org/
   Qt-KDE Wrapper project: http://iidea.pl/~js/qkw/

[prev in list] [next in list] [prev in thread] [next in thread]