[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Please update tag for JuK in KDE 3.3.0
From: Michael Pyne <pynm0001 () comcast ! net>
Date: 2004-08-14 4:34:03
Message-ID: 200408140034.25849.pynm0001 () comcast ! net
[Download RAW message or body]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi all,
I've fixed two bugs today in JuK that, although neither would qualify as a
showstopper IMO, both could cause severe annoyance for the user. Also, both
fixes are simple fixes.
Bug #1, in playlistcollection.cpp:
The function open() was called to re-scan a directory after receiving the
dirty() signal from KDirWatch. open() will post a dialog to the user if the
current playlist isn't the Collection List, which would be oh-so-annoying if
the directory being watched by KDirWatch has a lot of files. The fix is to
call the function that open() would call, addFiles(), so it's IMHO a safe
fix.
See Bug 87098.
Bug #2, also in playlistcollection.cpp:
The PlaylistCollection class sets itself up as the playlist interface for the
Player, but forgets to remove the connection after the destructor is called.
This seems to cause problems during shutdown if the JuK window is open,
leading to the horrible sight of Dr. Konqi on shutdown. :-( The fix is to
correctly remove the connection in the PlaylistCollection destructor. This
is also a safe fix IMHO.
See Bug 87051.
With all the above said, I'd like to ask that KDE_3_3_0_RELEASE be retagged so
that kdemultimedia/juk/playlistcollection.cpp is at revision 1.33.2.2, if
that is still possible. Thanks! :-)
Regards,
- Michael Pyne
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFBHZZAqjQYp5Omm0oRAs0gAKDT4OieMMdA7kWqsv8DP/KVs23eNgCfaWr6
+yxtnuLhCO7Pk8S3X7JLcMA=
=shdD
-----END PGP SIGNATURE-----
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic