[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: very uncool KJSDebugDialog bug
From: Ian Reinhart Geiser <ian () geiseri ! com>
Date: 2004-08-10 14:07:26
Message-ID: 200408101007.26762.ian () geiseri ! com
[Download RAW message or body]
On Tuesday 10 August 2004 09:51 am, David Faure wrote:
> The main change is arg(a,b,c) instead of arg(a).arg(b).arg(c).
> The QString::number is simply there because multi-arg needs strings.
> Please try the change, it should fix your problem :)
[...]
> See above.
Ah, now I see now, that makes more sense. Okay here is the patch.
Cheers
-ian reinhart geiser
--
------(Ian Reinhart Geiser)-----<geiseri@yahoo.com>-----
Fighting time, so hard I pray that this moment will last forever, and will the
world stay standing still at least for me.
-VNV Nation, Standing
["kjs_debug_bonzo_dialog.patch" (text/x-diff)]
Index: kjs_debugwin.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/ecma/kjs_debugwin.cpp,v
retrieving revision 1.38
diff -u -u -r1.38 kjs_debugwin.cpp
--- kjs_debugwin.cpp 6 Dec 2003 12:58:45 -0000 1.38
+++ kjs_debugwin.cpp 10 Aug 2004 14:06:22 -0000
@@ -57,6 +57,7 @@
#include <kconfigbase.h>
#include <kapplication.h>
#include <dcop/dcopclient.h>
+#include <kstringhandler.h>
#include "kjs_dom.h"
#include "kjs_binding.h"
@@ -830,9 +831,9 @@
Context ctx = m_execs[m_execsCount-1]->context();
SourceFragment *sourceFragment = m_sourceFragments[ctx.sourceId()];
QString msg = i18n("An error occurred while attempting to run a script on this page.\n\n%1 line %2:\n%3")
- .arg(sourceFragment->sourceFile->url)
- .arg(sourceFragment->baseLine+ctx.curStmtFirstLine()-1)
- .arg(exceptionMsg);
+ .arg(KStringHandler::rsqueeze( sourceFragment->sourceFile->url,80),
+ QString::number( sourceFragment->baseLine+ctx.curStmtFirstLine()-1),
+ exceptionMsg);
KJSErrorDialog dlg(dlgParent,msg,true);
dlg.exec();
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic