[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: fix for a few kurlrequester issues....
From:       David Faure <faure () kde ! org>
Date:       2004-08-10 8:34:32
Message-ID: 200408101034.32562.faure () kde ! org
[Download RAW message or body]

On Tuesday 10 August 2004 06:55, Ian Reinhart Geiser wrote:
> On Monday 09 August 2004 01:54 pm, David Faure wrote:
> > On Tuesday 03 August 2004 14:34, Ian Reinhart Geiser wrote:
> > > On Tuesday 03 August 2004 07:39 am, Waldo Bastian wrote:
> > > > On Tuesday 03 August 2004 07:25, Ian Reinhart Geiser wrote:
> [...]
> > This kind of reasoning seems to be against the "don't commit code you don't
> > understand" rule.
> Well can I at least get the other part of the patch applied?  That one at 
> least fixes an API bug. (you no longer need to subclass the ui file, just to 
> set a url filter.)
> 
> It introduces no bugs, strings, or out of the normal abilities, it just makes 
> the widget more usable in Qt designer.  

Yes, that looks fine to me (except for the int vs unsigned int mismatch?).

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]