[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Kcontrol memory leak
From:       Waldo Bastian <bastian () kde ! org>
Date:       2004-07-14 10:54:53
Message-ID: 200407141254.53548.bastian () kde ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed July 14 2004 01:35, Albert Astals Cid wrote:
> Looking again at KCModule i see that
>
> /**
>    * This is generally only called for the KBugReport.
>    * Override and have it return a pointer to a constant.
>    *
>    * @note it is mandatory to implement this function.
>    *
>    * @returns the KAboutData for this module
>    */
>   virtual const KAboutData *aboutData() const { return 0; }
>
> it says you have to override it.
>
> To make the code you suggest work, the virtual should be removed

No, it doesn't.

> to ensure 
> kcontrol modules make use of the setAboutData and KCModule's aboutData and
> not the redefined aboutData, 

If a module reimplements aboutData then it needs to take care of the object 
itself, if he uses setAuboutData then the module shouldn't reimplement 
aboutData and everything will be taken care of for him.

> but the BC will be broken (if i undestand 
> http://developer.kde.org/documentation/library/kdeqt/kde3arch/devel-binaryc
>ompatibility.html correctly) if the virtual is removed.

Yes, so that's no option nor is it needed.

Cheers,
Waldo
- -- 
bastian@kde.org  |   KDE Community World Summit 2004  |  bastian@suse.com
bastian@kde.org  | 21-29 August, Ludwigsburg, Germany |  bastian@suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFA9RD9N4pvrENfboIRAlcSAJwPfrKhbBfwBoH/sYKjC8+7kAhppACeMSf6
r7QtC9HBTdiMpxO1ocLbpkE=
=lXgr
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]