From kde-core-devel Wed Jul 14 10:37:59 2004 From: Lubos Lunak Date: Wed, 14 Jul 2004 10:37:59 +0000 To: kde-core-devel Subject: Re: Session management hickup Message-Id: <200407141238.00008.l.lunak () suse ! cz> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=108980134420584 On Friday 09 of July 2004 14:39, Rob Kaper wrote: > On Mon, Jun 14, 2004 at 12:14:47PM +0200, Lubos Lunak wrote: > > > From bool saveState( QSessionManager& ) in KMWSessionManaged, around > > > kmainwindow.cpp line 99: > > > > > > for (it.toFirst(); it.current(); ++it){ > > > if( it.current()->isVisible()) { > > > n++; > > > it.current()->savePropertiesInternal(config, n); > > > } > > > } > > > > > > Why is the isVisible here? > > > > cvs annotate is your friend : > > http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdelibs/kdeui/kmainwindow.cpp#re > >v1.105 > > > > I think it could be reverted and that particular problem fixed directly > > in Konqueror. > > Shoot, should've done so before the beta, can I still revert for 3.3? I've reverted that change. And there's actually no need to fix Konqueror, I already did so together with that change. > > It would reopen #59334, but it would fix the regression since 3.1 and I'd > rather re-break Konqueror than continue to break every application > depending on session management. > > Rob -- Lubos Lunak KDE developer --------------------------------------------------------------------- SuSE CR, s.r.o. e-mail: l.lunak@suse.cz , l.lunak@kde.org Drahobejlova 27 tel: +420 2 9654 2373 190 00 Praha 9 fax: +420 2 9654 2374 Czech Republic http://www.suse.cz/