[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Deprecation of KApplication::invokeBrowser()
From:       Matt Rogers <matt.rogers () kdemail ! net>
Date:       2004-06-10 2:57:20
Message-ID: 200406092157.20411.matt.rogers () kdemail ! net
[Download RAW message or body]

Hi,

I'd like to suggest the deprecation of the KApplication::invokeBrowser 
functions in favor of KRun::runURL since the latter uses the KDE settings for 
default browser and such.

The following patch accomplishes the above. Comments are welcome and 
appreciated.

Thanks,
Matt

["deprecate_invokebrowser.patch" (text/x-diff)]

Index: kapplication.h
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kapplication.h,v
retrieving revision 1.311
diff -u -p -r1.311 kapplication.h
--- kapplication.h	3 Jun 2004 12:54:00 -0000	1.311
+++ kapplication.h	10 Jun 2004 02:56:01 -0000
@@ -521,9 +521,9 @@ public slots:
    * @param startup_id for app startup notification, "0" for none,
    *           "" ( empty string ) is the default
    */
-  void invokeBrowser( const QString &url, const QCString& startup_id );
+  void invokeBrowser( const QString &url, const QCString& startup_id ) KDE_DEPRECATED;
   // KDE4 merge with above with startup_id = ""
-  void invokeBrowser( const QString &url );
+  void invokeBrowser( const QString &url ) KDE_DEPRECATED;
 
   /**
    * If the widget with focus provides a cut() slot, call that slot.  Thus for a


[prev in list] [next in list] [prev in thread] [next in thread]