[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: createStandardKWindow()
From:       Olivier Goffart <ogoffart () tiscalinet ! be>
Date:       2004-06-08 15:40:15
Message-ID: 200406081740.39291.ogoffart () tiscalinet ! be
[Download RAW message or body]


Le Mardi 8 Juin 2004 14:26, Benjamin Meyer a écrit :
> On Tuesday 08 June 2004 8:03 am, David Faure wrote:
> > On Tuesday 08 June 2004 02:07, Benjamin Meyer wrote:
> > > Also Added All to the enum.
> >
> > Is that a good idea, in terms of extensibility? If you add another
> > feature to the method later, you will be faced with two bad
> > possibilities: * adding the new feature to All, which would change
> > existing behavior, * or having a "All" that doesn't really mean "All",
> > since one feature will be missing...
> >
> > Apart from that, the patch looks ok to me now.
>
> Remove the All and comited.

The "All" was great. :-(

I guess you removed it only for the extensibility reason.
But you let a default value in the fonction which has exactly the same 
problem.

I would put back the All.

We could also do  All = 65535  which means "All" has automaticaly all flags. 
But i don't know if it's a good idea for backward compatibility


[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]