On Tuesday 08 June 2004 02:07, Benjamin Meyer wrote:
> Also Added All to the enum.
Is that a good idea, in terms of extensibility? If you add another feature
to the method later, you will be faced with two bad possibilities:
* adding the new feature to All, which would change existing behavior,
* or having a "All" that doesn't really mean "All", since one feature will
be missing...

Apart from that, the patch looks ok to me now.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).