[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Revised patch for KUser
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2004-06-07 22:50:14
Message-ID: 20040607225014.GE8828 () ugly ! local
[Download RAW message or body]

On Mon, Jun 07, 2004 at 09:40:00PM +0200, Jan Schäfer wrote:
> +KUser::KUser(const KUser & user) {
> +  d = user.d;
> +}
> +
KUser::KUser(const KUser & user) : d(user.d){}, i said.

> +  QValueList<KUserGroup> groups() const;
> +  QValueList<KUser> users() const;
>
now that is look at this, i'm not sure whether it is a good idea to
return lists of KUser[Group], as this may be excessively expensive.
maybe it would be better to return string lists and let the user create
the respective objects himself if necessary.
not sure about all{Users|Groups} ... without the auto-construction they
are trivially done with the posix functions, and i don't think we want
plain wrappers in the api?

greetings

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
[prev in list] [next in list] [prev in thread] [next in thread]