On Tuesday 11 May 2004 23:24, Waldo Bastian wrote: > (Wasn't there a webpage with common programming mistakes?) http://developer.kde.org/documentation/other/mistakes.html but for some reason it's not linked from index.html ? > [...] > Otherwise your loop aborts on the first non-element ( text or comments for > example ) Indeed. > Patch for kdeui attached. Ouch I had no idea that we had so many such loops.... Pretty hard to review (especially mergeXML) but I trust you to do it right :) -- David Faure, faure@kde.org, sponsored by Trolltech to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).