[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KEditToolBar inserts invisible line separator
From:       Sandro Giessl <ceebx () users ! sourceforge ! net>
Date:       2004-04-07 10:25:58
Message-ID: 200404071225.58982.ceebx () users ! sourceforge ! net
[Download RAW message or body]

Am Wednesday 07 April 2004 12:06 schrieb Jeroen Wijnhout:
> On Wednesday 07 April 2004 11:52, Waldo Bastian wrote:
> > On Wed April 7 2004 02:00, Sandro Giessl wrote:
> > > Some time ago, had the same idea and I have a quick&dirty patch
> > > for it lying around. ;)
> >
> > Nice :-) Looks good. Maybe you can add defines for
> > i18n("--- line separator ---") and  i18n("--- separator ---") so
> > that we can be sure that the exact same string is used in all
> > locations.
>
> Actually, this patch doesn't work here (KDE_3_2_BRANCH). First of all
> the two separator action do not appear at the top of list, the list
> seems to be ordered (the separator action used to appear at the top).
> Second when I try to  insert a " -- line separator -- ", a " --
> separator --- " is inserted.
Oups, I haven't checked if it still works (for HEAD). I will try and 
play around with the patch again.
But it won't make it into KDE_3_2_BRANCH anyway because there are new 
i18n() strings...

Sandro
[prev in list] [next in list] [prev in thread] [next in thread]