[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: Bug 73440: Konq deletes files when dragging
From:       "Dawit A." <adawit () kde ! org>
Date:       2004-03-03 2:18:22
Message-ID: 200403022118.22334.adawit () kde ! org
[Download RAW message or body]

On Tuesday 02 March 2004 10:10, Andras Mantia wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Sunday 15 February 2004 18:21, Dirk Mueller wrote:
> > I think this patch is wrong. You *can* write to a symlink, and it *has
> > to* overwrite the *destination* of the symlink.
> >
> > Otherwise whenever you overwrite a file that has a symlink in its path,
> > you're actually "detaching" it and you have two different files
> > afterwards. that is wrong.
>
> I've just run into this, although I'm not sure that it was because of this
> commit (it was with Kompare when applying a change to a symlink. The
> original file was not changed, but the symlink). But it's very bad if
> during a change or overwrite if the symlink is changed and not the file it
> points to. I've tried the edit in MC, it changes the original file.
> Overwrite in MC changes the original file. Overwrite with cp in a shell
> changes the original file. I think we can assume that a regular user would
> like to see that KDE behaves also like the other applications and changes
> the original file, and does not unlink the symlink and overwrite the
> symlink itself as it does now (just tested in Konqueror).

I have no idea if your problem is related to this patch either. However,
this is David's call :) I have posted the patch to fix the problem another way 
if necessary. See here: http://lists.kde.org/?t=107679141300008&r=1&w=2

-- 
Regards,
Dawit A.
"Preach what you practice, practice what you preach"
[prev in list] [next in list] [prev in thread] [next in thread]