[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: [PATCH] Fix kdenetwork/wifi compilation with iwlib27
From: Dominique Devriese <dominique.devriese () student ! kuleuven ! ac ! be>
Date: 2004-02-29 11:18:35
Message-ID: 878yim2kxg.fsf () student ! kuleuven ! ac ! be
[Download RAW message or body]
Piotr Szyma writes:
> Hi, Dominique Devriese(Friday 27 of February 2004 22:07):
>> As usual, this patch compiles for me, unless anyone objects, I am
>> going to commit this to 3_2_BRANCH and HEAD.
> Afair I committed a fix for that earlier, it works in PLD.
> http://lists.kde.org/?l=kde-devel&m=107539340828440&w=2
Okay, sorry that I missed your patch, but:
1 You posted it on the wrong list, kde-core-devel is better for this
sort of thing.
2 In your patch, the configure check is a bit superfluous, since libiw
already has a VERSION_WT macro defined.
3 AFAICS, Your patch only fixes the problems in
kdenetwork/wifi/kwireless/linuxwirelesswidget.cpp, not
in kdenetwork/wifi/wirelesstools.cpp, which still contained
iw_get_stats in KDE_3_2_BRANCH.
Anyway, apparently, there are now three separate solutions for this
problem in place now:
1 in HEAD, libiw.c source has been included in the
kdenetwork/wifi/libiw.cpp source
2 my patch fixes kdenetwork/wifi/wirelesstools.cpp in 3_2_BRANCH
3 your patch fixes kdenetwork/wifi/kwireless/linuxwirelesswidget.cpp
in HEAD and 3_2_BRANCH
I guess 1 is the ugliest, yet probably best solution ( due to the
wireless-tools people apparently not caring about API stability ). If
anyone interested in kdenetwork/wifi is reading this, it would be
useful to clear up this mess a bit.
cheers
domi
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic