From kde-core-devel Wed Feb 18 01:12:46 2004 From: Ingo =?iso-8859-1?q?Kl=F6cker?= Date: Wed, 18 Feb 2004 01:12:46 +0000 To: kde-core-devel Subject: Re: KListViewSearchLine Message-Id: <200402180212.59032 () erwin ! ingo-kloecker ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=107706685013179 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--Boundary-02=_awrMAmpHHO7PVmi" --Boundary-02=_awrMAmpHHO7PVmi Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 18 February 2004 01:03, Scott Wheeler wrote: > ...and since it's so much fun talking to myself -- here's a new > thingie that I added tonight -- this makes it possible (there's a > slot to turn this on and off) to show the parent items above matched > items in a tree like search: > > http://ktown.kde.org/~wheeler/images/kmail-search-threads.png That's really great stuff. But... (see below) > I've also update the API a little bit for this stuff and am attaching > a new version. There's been a reasonable amount of interest in this, > though such hasn't shown up here; there are certainly at least the > standard two places where this would be applicable in KDE that's > normally a requirement for a new class. If KMail is one of the standard two places then you have probably=20 forgotten that at least until the separate KDE PIM release but very=20 likely even afterwards all KDE PIM applications will have to depend on=20 nothing from post-3.2 kdelibs. > In the above screenshot I've also discovered a Qt bug that I haven't > come up with a good test-case for yet, but sometimes it shows items > that where setVisible(false) has been called, but only in a tree view > with multiple siblings on a given node (or at least from what I've > observed). Note the visible mail from Russel in the above. I'll see > if I can come up with a testcase and Qt patch in the next few days. > > So is this ok to check in? (Just the libs part; I'll deal with the > application patches later.) Again: Don't even think about adding anything to KMail that requires=20 more than kdelibs from KDE_3_2_BRANCH. But of course we could consider to add a temporary copy of=20 KListViewSearchLine to libkdepim because it's really a great new=20 feature. OTOH for KMail it should be possible to choose which=20 field/header (via a combobox) should be checked for matches. Actually=20 for KMail KMSearchRuleWidget should be used for this. So, I'm not in=20 favor of using KListViewSearchLine in KMail though the backend could=20 probably be used. Regards, Ingo --Boundary-02=_awrMAmpHHO7PVmi Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQBAMrwaGnR+RTDgudgRAtnrAKCUGWscYc+1IiiXwpAsMAtu/e+U8QCbBUW0 CRJx1o/+0g2aiCnr2zgna/s= =TN/Z -----END PGP SIGNATURE----- --Boundary-02=_awrMAmpHHO7PVmi--