[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Disabling aRts in knotify
From:       Aaron Seigo <aseigo () kde ! org>
Date:       2004-02-17 18:14:49
Message-ID: 200402171114.49202.aseigo () kde ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On February 16, 2004 15:04, Arnold Krille wrote:
> As it seems KNotify doesn't respect the setting in "Sound system". So I
> added another checkbox to the advanced playersettings to disable aRts. I
> didn't test wether aRts still gets started or not so far (I didn't want to
> stop my music :-) ) but It doesn't try to play sounds or connect to aRts
> anymore if told so.
> This would be a short time solution with the possibility for backporting
> imho.

instead of making the system notifications panel more complex and expecting 
people to actually find this new setting in the GUI, how about using the 
StartServer entry in kcmartsrc as the default when reading "User Arts" in 
knotify? this way stopping usage of aRts in the sound server has the expected 
results.

patch attached..

- -- 
Aaron J. Seigo
while (!horse()); cart();
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQFAMloZ1rcusafx20MRAl9KAJ41Q4y4Omc3wKTPLBa1KcYBEcXB7QCfXaNv
DE/uZaGdgeEWTZOBzVH2+SM=
=zaaM
-----END PGP SIGNATURE-----

["knotify_sans_arts.diff" (text/x-diff)]

Index: knotify/knotify.cpp
===================================================================
RCS file: /home/kde/kdelibs/arts/knotify/knotify.cpp,v
retrieving revision 1.88
diff -u -3 -d -p -r1.88 knotify.cpp
--- knotify/knotify.cpp	30 Oct 2003 14:12:25 -0000	1.88
+++ knotify/knotify.cpp	17 Feb 2004 18:14:09 -0000
@@ -123,7 +123,9 @@ int kdemain(int argc, char **argv)
     // abort this.
 
     KConfigGroup config( KGlobal::config(), "StartProgress" );
-    bool useArts = config.readBoolEntry( "Use Arts", true );
+    KConfig artsKCMConfig( "kcmartsrc" );
+    artsKCMConfig.setGroup( "Arts" );
+    bool useArts = config.readBoolEntry( "Use Arts", artsKCMConfig.readBoolEntry("StartServer",true) );
     bool ok = config.readBoolEntry( "Arts Init", true );
 
     if ( useArts && !ok )


[prev in list] [next in list] [prev in thread] [next in thread]