From kde-core-devel Thu Jan 29 10:46:46 2004 From: Waldo Bastian Date: Thu, 29 Jan 2004 10:46:46 +0000 To: kde-core-devel Subject: Re: [PATCH] KWallet bug with asynchronous wallet handling Message-Id: <200401291146.46697.bastian () kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=107537303804500 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Wed January 28 2004 23:26, George Staikos wrote: > On Wednesday 28 January 2004 17:20, Richard Smith wrote: > > Hi, > > > > I've discovered a bug in KWallet related to asynchronous wallet opening, > > resulting in it being impossible to open a wallet asynchronously if you > > don't use a KUniqueApplication. > > > > Basically, the problem was that when KWallet responds to the asynchronous > > wallet open command, it responds to the 'friendly name' of the sender > > DCOP app (that is, with the '-pid' bit removed), which is clearly > > incorrect. > > > > The attached patch fixes this. If no-one objects, I'll commit this to > > HEAD tomorrow. The more interesting question is, can this be committed > > against the 3.2 branch? Please review. > > Ouch, good catch. The patch looks correct, and I would appreciate if you > would apply to 3.2 branch and HEAD. For KDE 3.3 I suggest to use the async dcop calls that are provided by dcop. Cheers, Waldo - -- bastian@kde.org -=|[ SUSE, The Linux Desktop Experts ]|=- bastian@suse.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQFAGOSWN4pvrENfboIRAiHUAKCiZxEbHTC8NzqbYvqLir6mR0Sq0wCeLzJz rKLdWt2s12QU6ub3CtQnOkc= =nqua -----END PGP SIGNATURE-----