[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Patch for acinclude.m4.in
From:       Ben Burton <bab () debian ! org>
Date:       2004-01-24 23:35:38
Message-ID: 20040125103538.A30421 () digican ! ms ! unimelb ! edu ! au
[Download RAW message or body]


Hi.  Is it possible for someone to commit the following patch to
admin/acinclude.m4.in?

Specifically, the arguments to KDE_USE_QT are quoted in most places but
they are not quoted in the cases where the arguments are actually
provided.  Since $kde_qt_minversion and $kde_qt_verstring can be
expected to include symbols such as >=, it seems to me that these
arguments should be quoted everywhere.

(I ran across this problem when using the KDE autoconf stuff in a hybrid
project of my own.)

Thanks - Ben.


Index: acinclude.m4.in
===================================================================
RCS file: /home/kde/kde-common/admin/acinclude.m4.in,v
retrieving revision 2.439
diff -u -3 -p -r2.439 acinclude.m4.in
--- acinclude.m4.in	24 Jan 2004 12:26:49 -0000	2.439
+++ acinclude.m4.in	24 Jan 2004 23:33:57 -0000
@@ -1164,7 +1164,7 @@ if test -z "$2"; then
     kde_qt_minversion=">= 1.42 and < 2.0"
   fi
 else
-   kde_qt_minversion=$2
+   kde_qt_minversion="$2"
 fi
 
 if test -z "$3"; then
@@ -1188,7 +1188,7 @@ if test -z "$3"; then
     kde_qt_verstring="QT_VERSION >= 142 && QT_VERSION < 200"
    fi
 else
-   kde_qt_verstring=$3
+   kde_qt_verstring="$3"
 fi
 
 if test $kde_qtver = 3; then
[prev in list] [next in list] [prev in thread] [next in thread]