[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [PATCH] [REGRESSION] KProcess messes up session groups /
From:       Waldo Bastian <bastian () kde ! org>
Date:       2004-01-23 21:46:52
Message-ID: 200401232246.53831.bastian () kde ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The attached patch restores KProcess::start(DontCare) to the behavior of KDE 
3.1 and fixes BR73226

Cheers,
Waldo
- -- 
bastian@kde.org -=|[ KDE: K Desktop for the Enterprise ]|=- bastian@suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFAEZZMN4pvrENfboIRAriHAJ9X2IN6y/xYgnOidG99mVDaC4jD0gCgmHwg
G+YBgiA/kNWxZTaCojwBczA=
=WXbi
-----END PGP SIGNATURE-----

["kprocess.diff" (text/x-diff)]

Index: kprocess.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kprocess.cpp,v
retrieving revision 1.131
diff -u -r1.131 kprocess.cpp
--- kprocess.cpp	19 Jan 2004 12:00:07 -0000	1.131
+++ kprocess.cpp	23 Jan 2004 21:40:32 -0000
@@ -381,7 +381,10 @@
 
         setupEnvironment();
 
-        if (runmode == DontCare || runmode == OwnGroup)
+        if (runmode == DontCare)
+          setpgid(0,0);
+
+        if (runmode == OwnGroup)
           setsid();
 
         const char *executable = arglist[0];
Index: kprocess.h
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kprocess.h,v
retrieving revision 1.86
diff -u -r1.86 kprocess.h
--- kprocess.h	6 Oct 2003 07:45:39 -0000	1.86
+++ kprocess.h	23 Jan 2004 21:40:32 -0000
@@ -164,8 +164,7 @@
         */
        Block,
        /**
-        * Same as NotifyOnExit, but the process is run in an own session,
-        * just like with DontCare.
+        * Same as NotifyOnExit, but the process is run in an own session.
         */
        OwnGroup
   };


[prev in list] [next in list] [prev in thread] [next in thread]