[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KControl leak and changes in some kcm modules
From:       Aaron Seigo <aseigo () kde ! org>
Date:       2004-01-20 23:24:54
Message-ID: 200401201624.55138.aseigo () kde ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On January 20, 2004 15:47, Albert Astals Cid wrote:
> > This is a bit dangerous because there may be third party kcm modules that
> > return a class member as well and with these changes they will now crash.
>
> I know and i've also thought about it, but if not that way, how is the
> memory leak going to be sorted?

looking at the code, it seems to me that each kcm should take care of managing 
the memory of their own KAboutData object. TopLevel::activateModule() (which 
is where you put the delete statement) is called only when a module is 
started, and when the module is later deleted then it should also delete any 
memory it has allocated. if any KCMs don't do this, they should be fixed.

or am i missing something?

- -- 
Aaron J. Seigo
while (!horse()); cart();
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQFADbjH1rcusafx20MRAiitAJ9gZzRAAG3xwnxgQ+hlqtweCmrH/wCgrXbD
8HH0a6aiBFpof83OmCFP3OM=
=AWwj
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]