[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KControl leak and changes in some kcm modules
From:       Waldo Bastian <bastian () kde ! org>
Date:       2004-01-20 22:44:26
Message-ID: 200401202344.27015.bastian () kde ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue January 20 2004 23:23, Albert Astals Cid wrote:
> Hi, today i discovered some memory leakage in kcontrol toplevel.cpp, it was
> calling aboutData that returns a pointer to a KAboutData but never deleting
> it. I tried to fix it, but then realized that some kcm modules don't return
> a new KAboutData pointer each time. Some return a class member and some
> have a static variable, but the most return a new KAboutData each time, so
> i have looked at the CVS and chagned the few that didn't return a new
> KAboutData each time to do so. Here come the patches.
>
> Can you please review them and tell me if i can commit them.

This is a bit dangerous because there may be third party kcm modules that 
return a class member as well and with these changes they will now crash.

Cheers,
Waldo
- -- 
bastian@kde.org -=|[ KDE: K Desktop for the Enterprise ]|=- bastian@suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFADa9KN4pvrENfboIRAgvTAJ0WpjixvixeQ6NwtjnbpsedHcRBSACfUvuz
L7O4AWOCRLNTSRYaSlD4AII=
=Mrkr
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]