[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Patch for mmap problem in KConfigBackEnd, Bug #72586
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2004-01-16 0:07:33
Message-ID: 20040116000733.GA25867 () ugly ! local
[Download RAW message or body]

On Thu, Jan 15, 2004 at 11:15:15PM +0100, Waldo Bastian wrote:
> Ok, after reading up on "how to recover from SIGBUS on mmap" I now
> have a better patch :-)

extern "C" for the signal handler, please (btw, i think we still need to
check the entire kde codebase for that).

i don't like the mmap_can_jump; using a SA_ONESHOT handler seems cleaner
to me (say hi to sigaction).

there is no point in making mmap_map global; a volatile local variable
is sufficient.

greetings

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
[prev in list] [next in list] [prev in thread] [next in thread]