[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: "Malformed URL" error when splitting an empty view
From:       "Dawit A." <adawit () kde ! org>
Date:       2003-12-24 14:00:34
[Download RAW message or body]

On Wednesday 24 December 2003 04:37, David Faure wrote:
> On Wednesday 24 December 2003 06:00, Dawit A. wrote:
> > I was finally able to duplicate this bug, but not until I hacked one of
> > my profiles to change "View0_URL=about:blank" to "View0_URL=". If I do
> > that I can duplicate the above bug as well. So my advice to you is to
> > check your profiles for an empty "ViewX_URL" (X=number) entry and change
> > it to "ViewX_URL=about:blank" or delete the profile all together and
> > re-create it. I do not think the current code saves an empty URL anymore,
> > opting instead for "about:blank".
> >
> > I have tracked down the problem to how the view manager treats an empty
> > URL in kdebase/konqueror/konq_viewmgr.cc. The attached patch fixes the
> > problem.
>
> Looks ok, but didn't you mean about:blank instead of about:empty, in the
> patch?

Ooops, yes it should have read "about:blank". Fixed, tested and committed.

-- 
Regards,
Dawit A.
"Preach what you practice, practice what you preach"
[prev in list] [next in list] [prev in thread] [next in thread]