[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [PATCH] fix Details button size in KDialogBase
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2003-12-21 18:56:26
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

hi...

from the pixel-pushers department........

currently, if you have a KDialogBase dialog that uses the Details button, the 
Details button is mis-sized... this is beause the layout is turned off during 
resize and the vertical (or horizontal, depending on the orientation) size 
never gets set... this results in very bad looking dialogs, such as in the 
KKeyChooser dialog where the Advanced button is too large for the dialog and 
is cut off at the bottom ... the attached patch fixes it here, but i only 
have KDE built against Qt 3.2 to test it with... please review...

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
while (!horse()); cart();
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/5ezm1rcusafx20MRAj0eAKCVLHCU1O/ddwvc747rG0TETCpgUQCeOLU8
5xtrThFu59vDIFtq2XkKoGQ=
=Wljb
-----END PGP SIGNATURE-----

["kdialogbase_detailsbutton_size.diff" (text/x-diff)]

Index: kdialogbase.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdeui/kdialogbase.cpp,v
retrieving revision 1.90
diff -u -3 -d -p -r1.90 kdialogbase.cpp
--- kdialogbase.cpp	30 Nov 2003 21:55:27 -0000	1.90
+++ kdialogbase.cpp	21 Dec 2003 18:54:31 -0000
@@ -1137,14 +1137,10 @@ void KDialogBase::setDetails(bool showDe
      setButtonText(Details, d->detailsButton+ " <<");
      if (d->detailsWidget)
      {
-        if (layout())
-           layout()->setEnabled(false);
-        adjustSize();
         d->detailsWidget->show();
         if (layout())
         {
            layout()->activate();
-           layout()->setEnabled(true);
         }
      }
   }


[prev in list] [next in list] [prev in thread] [next in thread]