[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KMix
From:       Christian Esken <c.esken () cityweb ! de>
Date:       2003-12-06 21:14:21
[Download RAW message or body]

On Saturday 06 December 2003 07:00, Aaron J. Seigo wrote:
> hi...
>
> attached is a patch for review to KMix which fixes two things:
>
> 1) don't show the "Current mixer:" set of widgets if there is only one
> mixer. this is akin to the same fix made when this was displayed as a set
> of tab widgets; basically if there's only one mixer these widgets do
> nothing but clutter up the layout. seeing as that's the majority case, it
> should be hidden. this is a minor usability issue, but still....

Is on schedule for after KDE3.2. I believe wishlist items are not to be fixed 
anymore.
BTW: Why does your patch exchanges QHBoxLayout by QHBox?

>
> 2) proper hiding of the main window when clicking on the systray icon in
> certain situations. the comment in the code even references "LeftButton",
> but in the code it was "MidButton". oops. i've had this one laying around
> on my hard disk for a long while and apparently completely forgot about it.
> =/

Your fix is outdated. Don't apply it. The code already does it correctly, 
because it references the mouse button which shows the volume slider 
(currently middle mouse button).

Chris
[prev in list] [next in list] [prev in thread] [next in thread]