[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Fixing the KMix applet
From:       Christian Esken <c.esken () cityweb ! de>
Date:       2003-11-30 21:27:40
[Download RAW message or body]

On Sunday 30 November 2003 19:37, Andras Mantia wrote:
> Oops, bug in patch
> +               if ((m_direction != KPanelApplet::Right) && (m_direction ==
> KPanelApplet::Down))
>
> should be
>
> +               if ((m_direction != KPanelApplet::Right) && (m_direction !=
> KPanelApplet::Down) &&
> +                   (m_direction != KPanelApplet::Left) && (m_direction !=
> KPanelApplet::Up))
>
> You get the idea, don't you?

I get the idea. Thanks for the hint. But I applied a slightly different patch 
(only like this I can be sure to break nothing):

diff -u -r1.64 mixdevicewidget.cpp
--- mixdevicewidget.cpp 24 Nov 2003 22:44:48 -0000      1.64
+++ mixdevicewidget.cpp 30 Nov 2003 21:22:26 -0000
@@ -258,7 +258,8 @@
        // create record source LED
        if( m_mixdevice->isRecordable() && ! isSwitch() )
        {
-               layout->addSpacing( 2 );
+               if ( showRecordLED )
+                 layout->addSpacing( 2 );
                m_recordLED = new KLedButton( Qt::red,
                                m_mixdevice->isRecSource()?KLed::On:KLed::Off,
                                KLed::Sunken, KLed::Circular, this, 
"RecordLED" );


> And another bug: changing the direction of the sliders breaks the layout...

And changing the colors resizes the applet to the width of one slider or 
resets the applet to say "Invalid mixer".
[prev in list] [next in list] [prev in thread] [next in thread]