[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: modal dialog locking user's desktop
From:       David Faure <faure () kde ! org>
Date:       2003-11-25 7:46:12
[Download RAW message or body]

On Tuesday 25 November 2003 08:35, Aaron J. Seigo wrote:
> On Monday 24 November 2003 02:59, Unai Garro wrote:
> > The fix should be easy: making that dialog non-modal. I don't know if
> > there's a reason to keep it modal. That's why I'm sending the e-mail here.
> 
> as far as i can see there isn't a reason to keep it modal... the attached 
> patch adds a KIconDialog::showDialog() method that puts the dialog into a 
> non-modal mode and uses signals/slots.
> 
> i've tested it using both the openDialog() modal and showDialog() non-modal 
> methods and it works as expected. even clicking the property dialog's Ok or 
> Cancel buttons when the KIconDialog is up in nonmodal mode works fine.. 
> i tested KPropertiesDialog with these changes from both kicker and konqi... 

But somehow you also have to ensure that the user doesn't pop up the dialog
more than once, no? Also, what happens if the user closes the properties
dialog before closing the icon dialog?
(I'm not against this change, but I think it opens a new can of worms)

-- 
David FAURE, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]