[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: What IGS thinks about the Linux Desktop
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2003-11-25 6:04:39
[Download RAW message or body]

On Monday 24 November 2003 12:50, Ingo Klöcker wrote:
> Any objections against removing the two "Duplicate in ..." actions from
> the context menu?

only if we replace them with "View Document Source..." ;-)

patches attached for requisite review...

-- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
"Never weary, never dispair, never give in" - Winston Churchill


["konq_mainwindow.cc.diff" (text/x-diff)]

Index: konq_mainwindow.cc
===================================================================
RCS file: /home/kde/kdebase/konqueror/konq_mainwindow.cc,v
retrieving revision 1.1261
diff -u -3 -d -p -r1.1261 konq_mainwindow.cc
--- konq_mainwindow.cc	24 Nov 2003 13:48:18 -0000	1.1261
+++ konq_mainwindow.cc	25 Nov 2003 00:04:36 -0000
@@ -3976,22 +3976,12 @@ void KonqMainWindow::slotPopupMenu( KXML
 
   // Those actions go into the PopupMenuGUIClient, since that's the one defining \
them.  KAction *actNewWindow = 0L, *actNewTab = 0L;
-  if ( openedForViewURL )
-  {
-    actNewWindow = new KAction( i18n( "Duplicate in New &Window" ), "window_new", 0, \
                this, SLOT( slotPopupNewWindow() ), \
                konqyMenuClient->actionCollection(), "newview" );
-    actNewWindow->setStatusText( i18n( "Duplicate the document in a new window" ) );
-    actNewTab = new KAction( i18n( "Duplicate in &New Tab" ), "tab_new", 0, this, \
                SLOT( slotPopupNewTab() ), konqyMenuClient->actionCollection(), \
                "openintab" );
-    actNewTab->setStatusText( i18n( "Duplicate the document in a new tab" ) );
-  }
-  else
+  if( !openedForViewURL && !isIntoTrash )
   {
-    if( !isIntoTrash )
-      {
-	actNewWindow = new KAction( i18n( "Open in New &Window" ), "window_new", 0, this, \
                SLOT( slotPopupNewWindow() ), konqyMenuClient->actionCollection(), \
                "newview" );
-	actNewWindow->setStatusText( i18n( "Open the document in a new window" ) );
-	actNewTab = new KAction( i18n( "Open in &New Tab" ), "tab_new", 0, this, SLOT( \
                slotPopupNewTab() ), konqyMenuClient->actionCollection(), "openintab" \
                );
-	actNewTab->setStatusText( i18n( "Open the document in a new tab" ) );
-      }
+      actNewWindow = new KAction( i18n( "Open in New &Window" ), "window_new", 0, \
this, SLOT( slotPopupNewWindow() ), konqyMenuClient->actionCollection(), "newview" ); \
+      actNewWindow->setStatusText( i18n( "Open the document in a new window" ) ); +  \
actNewTab = new KAction( i18n( "Open in &New Tab" ), "tab_new", 0, this, SLOT( \
slotPopupNewTab() ), konqyMenuClient->actionCollection(), "openintab" ); +      \
actNewTab->setStatusText( i18n( "Open the document in a new tab" ) );  }
 
   if (m_currentView->isHierarchicalView())


["khtml_popupmenu.rc.diff" (text/x-diff)]

Index: khtml_popupmenu.rc
===================================================================
RCS file: /home/kde/kdelibs/khtml/khtml_popupmenu.rc,v
retrieving revision 1.29
diff -u -3 -d -p -r1.29 khtml_popupmenu.rc
--- khtml_popupmenu.rc	14 Oct 2003 22:48:54 -0000	1.29
+++ khtml_popupmenu.rc	25 Nov 2003 00:02:59 -0000
@@ -20,6 +20,7 @@
  <Action name="copyimagelocation" />
  <Action name="viewimage" />
  <Separator weakSeparator="1" />
+ <Action name="viewDocumentSource" />
  <Action name="security" />
  <Action name="setEncoding" />
 </Menu>


[prev in list] [next in list] [prev in thread] [next in thread]