[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    KGpg patch to improve kde compliance & spare code
From:       bj () altern ! org
Date:       2003-11-16 17:25:28
[Download RAW message or body]


I just realized that you can make a nice file overwrite dialog with 
KIO::RenameDlg. KGpg previously used its own dialog to ask for file 
overwrite.  Applying this simple patch in 3 files in KGpg would allow to 
delete KGpg's custom overwrite dialog (kgpgfast.cpp and kgpgfast.h), making 
KGpg more KDE compliant and thus remove about 150 lines of code.

The i18n string "File Already Exists" is already present in KGpg's po file

Is it ok to commit ?



Index: kgpg/kgpglibrary.cpp
===================================================================
RCS file: /home/kde/kdeutils/kgpg/kgpglibrary.cpp,v
retrieving revision 1.19
diff -u -3 -p -r1.19 kgpglibrary.cpp
--- kgpg/kgpglibrary.cpp	23 Sep 2003 19:47:11 -0000	1.19
+++ kgpg/kgpglibrary.cpp	16 Nov 2003 17:14:32 -0000
@@ -80,11 +80,14 @@ void KgpgLibrary::fastencode(KURL &fileT
         QFile fgpg(dest.path());
 
         if (fgpg.exists()) {
-                KgpgOverwrite *over=new KgpgOverwrite(0,"overwrite",dest);
-                if (over->exec()==QDialog::Accepted)
-                        dest.setFileName(over->getfname());
-                else
-                        return;
+			KIO::RenameDlg *over=new KIO::RenameDlg(0,i18n("File Already 
Exists"),QString::null,dest.path(),KIO::M_OVERWRITE);
+		    	if (over->exec()==QDialog::Rejected)
+	    		{
+                	delete over;
+                	return;
+            		}
+	    		dest=over->newDestURL();
+	    		delete over;
         }
 
         KgpgInterface *cryptFileProcess=new KgpgInterface();

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]