[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Keramik &  toolbarbutton mouse-over...
From:       Maks Orlovich <mo002j () mail ! rochester ! edu>
Date:       2003-11-11 3:37:35
[Download RAW message or body]

On Monday 10 November 2003 04:29 pm, Craig Drummond wrote:
> Hi,
>
> I've noticed for sometime that a lot (all?) of KDE styles do not have the
> mouse-over effect on toggle/radio toolbar buttons - i.e. KToggleAction and
> KRadioAction. This is most noticeable on konqueror's list and icon view
> selection buttons - or KWords Bold, Italic, Underline, etc buttons.
> Standard Qt toolbarbuttons are not affected, so I assume the problem is
> somewhere in the action classes.
>
> Having looked at the kactionclasses.cpp file I can't find anything in there
> that would seem to be causing this effect. I noticed that Mosfet's liquid
> style does have the mouse-over working, and the attatched patch fixes
> Keramik in a similar fashion. The only change is checking for
> Style_MouseOver in drawComplexControl(CC_ToolButton). Shall I commit? If

Good catch, thanks. However, notice how this does not work with Qt's own 
styles either, so I think it would be best to fix KToolBarButton. In fact, I 
just did that -- it now sets the Raise flag on all hovered buttons.

Even with change there is still a slight difference --- toggle buttons do not 
get highlift font color when text  is on on hover like others do.. That's 
because the m_isRaised() is essentially hasMouse() && !toggleButton() done a 
difficult way (and something that can probably probably be a bit 
simplified/cleaned up for 3.3). I am not sure whether that's worth changing 
that bit of behavior or not. 
[prev in list] [next in list] [prev in thread] [next in thread]