From kde-core-devel  Sun Oct 26 09:30:48 2003
From: Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date: Sun, 26 Oct 2003 09:30:48 +0000
To: kde-core-devel
Subject: Re: [PATCH] Fix loading 22x22 icons with KIconLoader
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=106716084902710
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary-02=_OR5m/0KMZ5t9+Xz"


--Boundary-02=_OR5m/0KMZ5t9+Xz
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Sunday 26 October 2003 02:21, Antonio Larrosa Jim=E9nez wrote:
> El Saturday 25 October 2003 19:31, Ingo Kl=F6cker escribi=F3:
> > Hi,
>
> Hello Ingo,
>
> > the attached patch should fix the problem with the icons in the
> > system tray. For example klipper and ksirc both have a 22x22 icon.
> > But the iconloader loads the small 16x16 icons and then scales them
> > to 22x22 which gives them a blurry look (cf. Eva's message "Am I
> > the only one who thinks this is ugly?").
>
> I'm sorry because being the maintainer of those classes I should have
> fixed it a long time ago, but I'm lately very busy (I've just
> finished working today, at _this_ hour). So thanks for fixing it.
>
> But I'm afraid there's still some problems. The code you fixed was
> inside a "if (group =3D=3D KIcon::User)" block, and definitely, icons
> that are used in the system tray should _never_ be User icons, so
> even if your patch made the icons look good, it seems the real
> problem is somewhere else.

Unfortunately this change didn't fix the problem with the system tray=20
icons. The ( group !=3D KIcon::User ) branch looked okay so I thought the=20
problem would be in the ( group =3D=3D KIcon::User ) branch which is called=
=20
as fallback from the "!=3D" branch.

> Also, the behavior of loadIcon is broken now. There are two kind of
> icons, "User" icons, and the rest (themed icons). If you ask for a
> User icon, the size should be ignored because user icons are not
> themable, are not resizable, etc. So your version will modify the
> request to iconPath and just ask for icons of a given size without
> telling it that you really want a User icon, and then iconPath will
> look in the directories for themed icons, instead of the directory
> for User icons.

Hmm, that's of course due to the fact that someone thought it would be=20
cool to save a parameter in iconPath by passing size or group with the=20
same parameter. Obviously this way some information is lost. I think=20
the proper way to fix this is to deprecate iconPath and to add a new=20
iconPath which takes size _a_ icon group as parameter.

Adding overloads is BIC AFAIK so this shouldn't be a problem, right?

Regards,
Ingo

--Boundary-02=_OR5m/0KMZ5t9+Xz
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/m5ROGnR+RTDgudgRAuzTAKCfrWzeDNw5rsMSKvLZRzoo1wd13gCgodDS
S/6deEWRG9bBACsVi7IkIvU=
=NNn6
-----END PGP SIGNATURE-----

--Boundary-02=_OR5m/0KMZ5t9+Xz--