[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Serious kdecore problems
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2003-10-03 13:00:04
[Download RAW message or body]

On Friday 03 of October 2003 14:14, Carsten Pfeiffer wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
>
> On Friday 03 October 2003 12:58, George Staikos wrote:
> >    Removing the part in kinstance (line 200) still has left me without a
> > single reproduction of the crash after several hours.  I tried everything
> > that used to work to make it crash and nothing happened yet.
>
> Can you try to find out whether (and from where) a KIconLoader instance is
> deleted? I.e. add a kdBacktrace() to its destructor.

 KIconLoader seems to be destroyed only in ~KInstance. And while I don't know 
the code related to this much, it seems to me KInstance is not destroyed 
doing icon changes etc. The global (from KApplication) KInstance is destroyed 
only at exit., the only problem with that could be a wild pointer walking 
over its data.

 KInstances created by KParts are destroyed when the library is unloaded. In 
this case it would be possible something is accessing some already destroyed 
KInstance or its KIconLoader, but then that's a bug of course, that's 
accessing something that's from a no longer loader library. Maybe checks 
should be added whether the used KInstance and/or KIconLoader still exist.

>
> You might do the same for ~KIconFactory.

 That doesn't  matter. KIconFactory keeps only things like icon name, the only 
thing that can go wrong is the KIconLoader pointer. And this can go wrong 
only if an icon created using already deleted KInstance still exists -> not 
KIconFactory bug.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak@suse.cz , l.lunak@kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/

[prev in list] [next in list] [prev in thread] [next in thread]