From kde-core-devel Thu Oct 02 05:07:02 2003 From: Benjamin Meyer Date: Thu, 02 Oct 2003 05:07:02 +0000 To: kde-core-devel Subject: Re: KConfig XT: kconfig_compiler & friends X-MARC-Message: https://marc.info/?l=kde-core-devel&m=106507219611784 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thursday 02 October 2003 12:20 am, George Staikos wrote: > On Wednesday 01 October 2003 22:52, Benjamin Meyer wrote: > > Anyone object to me moving waba's kautoconfigdialog additions to a new > > class called kconfigdialogmanagerdialog in kdeui so I can revert out the > > kautoconfigdialog change while keeping cvs compiling? > > Why don't you wait until at least tomorrow so you can properly discuss > instead of piling on the diffs in cvs? That seems more reasonable to me. Whenever anyone asks for objects it usual takes a few days for someone to pipe up, I am in no rush, just annoyed I agree that this is the route that we want to move to, but I just feel it was impertinent and the transition was obtrusive. There was no post on the lists for review or comment until after all of the commits had gone in (with the dependencies of apps nonless). For a component that it is expecting (almost) every application in KDE to use it I expected a little more discusion. In the past it seemed like anything to be added to the core libs got a good week or two _at least_ of discusion and improvments before going in. The KDE CVS Commit Policy talks about this: 1 - Think twice before committing. 7 - Respect special commit policies set by the release plans. 8 - Respect the policies of application and library maintainers, and consult with them before making large changes. 9 - When you plan to make changes which affect a lot of different code in CVS, announce them on the relevant mailing list in advance. 10 - Don't commit changes to the public API of libraries without prior review by other developers. - -Benjamin Meyer - -- Public Key: http://www.csh.rit.edu/~benjamin/public_key.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE/e7J21rZ3LTw38vIRAiG+AKCp7IoK3axePnSIpkUEiXBGvpboqACfV/4N jEhe/RAA3Qzj1HsztR1jp/Q= =tzNw -----END PGP SIGNATURE-----