From kde-core-devel  Tue Sep 16 20:23:37 2003
From: Ravikiran Rajagopal <ravi () ee ! eng ! ohio-state ! edu>
Date: Tue, 16 Sep 2003 20:23:37 +0000
To: kde-core-devel
Subject: Re: [PATCH] Fix for bug 51571 - please review
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=106374555713542

On Tuesday 16 September 2003 03:00 pm, Christian Esken wrote:
> >   This is a "fix" for http://bugs.kde.org/show_bug.cgi?id=51571 which
> > uses a different (nicer?) hack to handle maximized windows. Ok to commit?
>
> Can you explain why this fixes the bug?
> I have read the patch and it looks like the only difference is how the
> maximization state is saved in the config.

Thanks for reviewing the patch. I made a mistake. The idea is to store 
maximization state independent of the desktop size. I forgot that sizes are 
stored separately for each screen resolution. Lunak's current approach 
handles all normal cases correctly and fixes 51571 anyways, and the extra 
complexity of code required to handle resolution-switching is not worth it. 
My patch should be ignored.

However, I do believe that the "right" way to store maximization and other 
states is via flags, but, again, it is probably not worth the added 
complexity.

Regards,
Ravi