[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] making KDE more independent from X11
From:       Zack Rusin <zack () kde ! org>
Date:       2003-08-28 19:12:43
[Download RAW message or body]

On Thursday 28 August 2003 12:33, Holger Schroeder wrote:
> i would like to apply this today or tomorrow, if there are no
> objections.

Ave,
you haven't diffed this against head and you included some added 
patches. For example I fixed this a while ago and it's not windows 
specific ;) :
diff -u -r1.3 kspellui.ui
--- kdeui/kspellui.ui	23 Aug 2003 16:16:30 -0000	1.3
+++ kdeui/kspellui.ui	28 Aug 2003 16:18:59 -0000
@@ -1,4 +1,4 @@
-<!DOCTYPE UI><UI version="3.2" stdsetdef="1">
+<!DOCTYPE UI><UI version="3.1" stdsetdef="1">
I think what you will have to do is post individual patches for all 
directories in kdelibs and kdebase, for maintainers to have a look at 
them. 
And I'm not sure if we want to have things like the following for the 
sake of compiling on windows:
   case AvailLeft: {
+#if defined Q_WS_X11 && ! defined K_WS_QTONLY
     QRect clipped = info.workArea().intersect(sg);
     return Number(clipped.x()-sg.x());
+#else
+    return Number(10);
+#endif
I just don't see it working. I think the problem is that pretty much 
everything is now ifdefed, it wouldn't be a bad thing but it's just 
covering the problem. Like in the above example we would need an 
implementation of KWinModule that works on Windows. All not ported 
classes require now ifdefs and it adds a burden on maintainers who now 
need to know exactly what works on windows and ifdef it, or else we're 
gonna be left with not compiling kdelibs on windows with a huge number 
of ifdefs all over the place. Which is why I suggest that you simply 
send diffs against the individual libraries so that maintainers of each 
can look at them and decide whether they want to apply them.

Zack


-- 
Those who live by the sword get shot by those who don't. 
[prev in list] [next in list] [prev in thread] [next in thread]