[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] kdebase/kicker/toolbar: do not split window caption
From:       John Firebaugh <jfirebaugh () kde ! org>
Date:       2003-08-24 22:53:26
[Download RAW message or body]

On Sunday 24 August 2003 02:20 pm, Stanislav Kljuhhin wrote:
> please review and consider applying.

> +        QToolTip::add( this, currentTooltip="<qt><nobr>" + QStyleSheet::
escape(name()) + "</nobr></qt>" );

Ugh. Please don't assign variables as a side effect.

Besides that, I think this will make unreasonably wide tooltips, and feels 
like a hack to me. Please consider improving Qt's line-break algorithm 
instead.

-John
[prev in list] [next in list] [prev in thread] [next in thread]