[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    (PATCH) Default KDE factory erases other factories
From:       Simon Perreault <nomis80 () linuxquebec ! com>
Date:       2003-07-29 19:10:32
[Download RAW message or body]

Hi,

I am using QDesigner-made image libraries. This installs a default 
QMimeSourceFactory so that one can easily fetch an image using the filename 
of the image. The factory is installed before KApplication installs the 
default factory provided by KInstance. KApplication installs its default 
factory in a way that erases any previously set factories (there can be 
multiple default factories).

Would the following patch be acceptable? This is how the QDesigner-made image 
library installs its default mime source factory. See the documentation for 
QMimeSourceFactory::addFactory() for more information.

I'll commit this change if I don't get any replies.


--- kapplication.cpp    29 Jul 2003 16:44:37 -0000      1.604
+++ kapplication.cpp    29 Jul 2003 19:03:53 -0000
@@ -731,11 +731,11 @@ void KApplication::init(bool GUIenabled)
     kdisplaySetFont();
 //    kdisplaySetPalette(); done by kdisplaySetStyle
     propagateSettings(SETTINGS_QT);

     // Set default mime-source factory
-    QMimeSourceFactory::setDefaultFactory (mimeSourceFactory());
+    QMimeSourceFactory::defaultFactory()->addFactory( mimeSourceFactory() );

     KConfigGroupSaver saver( config, "Development" );
     if( config->hasKey( "CheckAccelerators" ) || config->hasKey( 
"AutoCheckAccelerators" ))
         d->checkAccelerators = new KCheckAccelerators( this );
   }

-- 
Simon Perreault <nomis80@linuxquebec.com>
http://nomis80.org
[prev in list] [next in list] [prev in thread] [next in thread]