From kde-core-devel  Thu Jul 17 12:49:17 2003
From: David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date: Thu, 17 Jul 2003 12:49:17 +0000
To: kde-core-devel
Subject: Re: [PATCH] : KIO::chmod that uses KURL::List
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=105844625717726

On Thursday 17 July 2003 22:40, kzk wrote:
> Hi.
> 
> I implemented KIO::chmod that uses KURL::List in kdelibs/kio/kio/chmod.h, 
> kdelibs/kio/kio/chmod.cpp
>  
> This function is only wrapper.

Your idea sounds good, but I'm afraid the "mask" should be removed, since
there's no way to know the current permissions of the urls - so you can only
use chmod(list of urls) to apply a complete set of permissions to all files,
you can't selectively change only one bit on them (like one can do with the mask).

To be more precise, the current line 79, which uses item->permissions(), will
always get -1 in your case, which will result in wrong stuff being done, unless
m_mask is 0777 (or so).

-- 
David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions