[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: PATCH: mouse acceleration improvements
From:       Dirk Mueller <mueller () kde ! org>
Date:       2003-05-17 15:25:18
[Download RAW message or body]

Moin Daniel!

> can someone check this patch? It implements wishes 27698: "fractional mouse 
> acceleration values" and 31189: "Mouse acceleration with threshold 0 not 
> possible". It works for me, but I'm mot sure if int() and round() are used 
> correctly.

The patch seems overly complicated and confusing to me.. it does not change 
the return value of getAccel to double / float. 

Also, I don't see the reason for storing the denominator in a configuration 
file, its constant. 

I would just fix the one line that passes the value to XChangePointer to 
generate a denomiator like "fract(double_accel * 10) % 10", and you're done. 


-- 
Dirk
[prev in list] [next in list] [prev in thread] [next in thread]